Zeeshan Ali Khan

Results 481 comments of Zeeshan Ali Khan

> I have sent out an inquiry whether they would accept a PR in that direction. Could you please point out to where you asked? I don't see anything [here](https://github.com/smoltcp-rs/smoltcp/issues)....

What about `SO_PEER_FD` support? `nix` supports it and it's very similar to `rustix::net::sockopt::socket_peercred`. It's super important for the moden Linux userspace (systemd and services/apps above).

> This one [#1474](https://github.com/bytecodealliance/rustix/pull/1474)? Ah yes. That's the one. :)

> Why is it a breaking change? Because currently the struct is explicity declared `pub` by the macro. After this change, the default will not be `pub`. I thought about...

> However, with heapless 0.9.1, there seems to be a significant regression Wow, the regression indeed is a quite severe. 😢 If we had benchmarks in the repo and ran...

hash32 1.0 was release a few months ago so that's not blocker anymore but this will be a breaking change so it has to be coordinated with all other breaking...

@newAM Awesome! I converted to draft to avoid accidental merging. I hope you don't mind. :)

> Adds a basic fuzzing test harness using `cargo-fuzz` to run randomized tests against the `Vec` type. I'm a bit puzzled as to what is being tested here. :thinking: Typically...

> t would probably be more useful in a `String` fuzzer, Not really. It doesn't do any parsing either. It just stores whatever you give it. > If you have...

> The reason I suggested `String` is because it does "parse" in a certain sense: https://github.com/rust-embedded/heapless/blob/main/src/string/mod.rs#L245 > > It decodes from UTF-16 and UTF-8, which is currently handled by the...