Zack Moore

Have you considered moving the logic out of the modal and into a global `on-click-outside` modifier? Might be a useful modifier to ship with HDS.

> @zamoore can you please move this PR to draft? the reasons I am asking are 1) we tend to avoid doing the conversion of two different/distinct components in the...

> Within the showcase, it looks like there are several instances where we have styles targeting `.flight-icon` that should be updated. I think that will resolve most of the regressions...

> > The remaining ones are necessary > > Can you expand a bit on why so that we understand a bit better? Sure, the last 2 examples of it...

Introduces breaking changes. We're holding off on merging this until we're ready to introduce a new major upgrade.

Closing in favor of a nonbreaking solution https://github.com/hashicorp/design-system/pull/3189/files

Closed in favor of https://github.com/hashicorp/design-system/pull/2347

The 2 failing tests are in the parent branch. Please see https://github.com/hashicorp/design-system/tree/3620-add-yield-to-list-item-interactive

> A few spots you might want to remove references to `ember-flight-icons` packages: > > https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/package.json#L18 > > https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/package.json#L50 > > https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/ember-cli-build.js#L21 > > https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/types/global.d.ts#L12 Thanks for the review @aklkv...

Closing in favor of mergin with website updates in this [PR](https://github.com/hashicorp/design-system/pull/2338)