hashicorp
Pagination TS conversion
:pushpin: Summary
If merged, this PR converts the Hds::Pagination component and its children to TS
:link: External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-2707
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| hds-showcase | ✅ Ready (Inspect) | Visit Preview | Aug 28, 2024 4:32pm |
| hds-website | ✅ Ready (Inspect) | Visit Preview | Aug 28, 2024 4:32pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@zamoore can you please move this PR to draft? the reasons I am asking are 1) we tend to avoid doing the conversion of two different/distinct components in the same PR, and 2) all the Hds::Form-related conversion will be done in the same batch (probably by @alex-ju).
PS: I am not sure if you have seen this file, it’s the list of components that need to be converted to TS, with their dependencies. If one component has a dependency, we should do the dependency first
@zamoore can you please move this PR to draft? the reasons I am asking are 1) we tend to avoid doing the conversion of two different/distinct components in the same PR, and 2) all the
Hds::Form-related conversion will be done in the same batch (probably by @alex-ju).PS: I am not sure if you have seen this file, it’s the list of components that need to be converted to TS, with their dependencies. If one component has a dependency, we should do the dependency first
@didoo Sure thing, would we want to wait to merge the changes to Pagination until the dropdown work is done as part of the batched form conversion work then? Or are you comfortable with merging to dropdown work now in a separate PR?
@zamoore can you please move this PR to draft? the reasons I am asking are 1) we tend to avoid doing the conversion of two different/distinct components in the same PR, and 2) all the
Hds::Form-related conversion will be done in the same batch (probably by @alex-ju). PS: I am not sure if you have seen this file, it’s the list of components that need to be converted to TS, with their dependencies. If one component has a dependency, we should do the dependency first@didoo Sure thing, would we want to wait to merge the changes to Pagination until the dropdown work is done as part of the batched form conversion work then? Or are you comfortable with merging to dropdown work now in a separate PR?
I would prefer to wait if you don't mind (I made the same thing here, so don't worry: https://github.com/hashicorp/design-system/pull/2094)
you probably saw this @zamoore, but I ported form/select/base together with the rest of the form conversions, so this will require a rebase, then we can focus on the pagination bits
