hashicorp
`FlightIcon` => `Hds::Icon` Migration - `website`
:pushpin: Summary
If merged, this PR updates instances of FlightIcon within website to use the Hds::Icon component.
:link: External links
Jira ticket: HDS-3708
:speech_balloon: Please consider using conventional comments when reviewing this PR.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| hds-showcase | ✅ Ready (Inspect) | Visit Preview | Aug 22, 2024 6:47pm |
| hds-website | ✅ Ready (Inspect) | Visit Preview | Aug 22, 2024 6:47pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
A few spots you might want to remove references to ember-flight-icons packages:
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/website/package.json#L20
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/website/package.json#L51
Unless there is an objection from someone, I would target these straight to main as there shouldn't be a need to stage them in a feature branch.
Within the showcase, it looks like there are several instances where we have styles targeting .flight-icon that should be updated. I think that will resolve most of the regressions seen in Percy.
Within the showcase, it looks like there are several instances where we have styles targeting
.flight-iconthat should be updated. I think that will resolve most of the regressions seen in Percy.
@didoo @alex-ju - The remaining ones are necessary. This is ready for re-review
The remaining ones are necessary
Can you expand a bit on why so that we understand a bit better?
The remaining ones are necessary
Can you expand a bit on why so that we understand a bit better?
Sure, the last 2 examples of it being targeted with CSS are in showcase/app/styles/showcase-pages/icon.scss and showcase/app/styles.scss. These two are still used to style the FlightIcon examples we have at foundations/icon
Shouldn't those be getting converted as well, or are we leaving them behind as examples for some reason?
Shouldn't those be getting converted as well, or are we leaving them behind as examples for some reason?
Agree with Brian. things like showcase/app/templates/foundations/icon.hbs should be removed at this point as we don't plan any further changes to the ember-flight-icons
things like showcase/app/templates/foundations/icon.hbs should be removed at this point as we don't plan any further changes to the ember-flight-icons
~~Recognizing that I've sent us into a bit of a loop on this, I would think we'd want this page to still exist but use <Hds::Icon> moving forward?~~
This is already happening on the icon showcase page. Ignore me 😄