hashicorp
`FlightIcon` => `Hds::Icon` Migration - `showcase`
:pushpin: Summary
If merged, this PR updates instances of FlightIcon within showcase to use the Hds::Icon component.
:link: External links
Jira ticket: HDS-3707
:speech_balloon: Please consider using conventional comments when reviewing this PR.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| hds-showcase | ✅ Ready (Inspect) | Visit Preview | Aug 13, 2024 9:59pm |
| hds-website | ✅ Ready (Inspect) | Visit Preview | Aug 13, 2024 9:59pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
A few spots you might want to remove references to ember-flight-icons packages:
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/package.json#L18
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/package.json#L50
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/ember-cli-build.js#L21
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/types/global.d.ts#L12
A few spots you might want to remove references to
ember-flight-iconspackages:https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/package.json#L18
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/package.json#L50
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/ember-cli-build.js#L21
https://github.com/hashicorp/design-system/blob/64a0cc615e5b2e55506f762b573e5c6e2b5a82f1/showcase/types/global.d.ts#L12
Thanks for the review @aklkv - We're not quite ready to remove ember-flight-icons entirely, but have deprecated it. Its integration tests are still being run via showcase. I believe all of these will need to remain for now.