Hiroaki Yutani

@clauswilke > making them aesthetics I' trying this in #3121. Is this what you expect?

Thanks for investigating this. I didn't know the mechanism around `plot_env`. At first, ggplot2 only looks up in global environment, but started to check the package environment by this commit:...

> do we want to encourage this usage pattern? Does anybody use it? I really don't know, sorry. I didn't even know (or completely forget) that we can override the...

By the way, is this related to #2691? If we can set the default scale by setting the default theme, probably we don't need to tweak globals (or some environments)...

> It appears that quosures within the mapping and layers elements are responsible. Has there been a recent change? I don't think so. Quosures capture environments in nature, and layers...

Thanks, I totally agree with you.

Btw, as https://github.com/tidyverse/ggplot2/pull/3828 gets merged, I guess overriding `scale_colour_discrete` on the global environment is now superseded. Maybe we can take these two steps: 1. Warn when `scale_colour_discrete` is found on...

> not just color I see. Sorry for my confusion.

> If you did want to protect against non-data.frame type uses for s I think it would be better to call `as.data.frame()` on them and put the burden on to...

Hmm, curious. conflr checks the existing attachments and depending on whether there's the one with the same `title` (i.e., filename), it chooses the proper method. But, the error `Cannot add...