Yacin Tmimi comments

Results 716 comments of


                                            Yacin Tmimi

`rustfmt` leaves an extra space after `self` in function signature

@raheja15 It's my expectation that the blank line would be removed. Could you elaborate on your explanation with some example code snippets. Are you saying that you tried to make...

Fix Comment Preservation in PatKind::Paren Patterns

@yuvraj-wale unfortunately we can't accept these changes as is since they modify the formatting of already formatted code. rustfmt has strong guarantees about not introducing stable formatting changes so you'll...

Fix Comment Preservation in PatKind::Paren Patterns

Great. Let me know if you need any pointers on how to get started

Fix Comment Preservation in PatKind::Paren Patterns

I'm wondering if `overflow::rewrite_with_parens` is the right thing to call here since it seems to be the source of a lot of the issues you're running into. You might only...

Fix Comment Preservation in PatKind::Paren Patterns

@yuvraj-wale possibly. I think you'll need to add test cases to this PR to know for sure.

panic: `Option::unwrap()` on a `None` value

@langston-barrett thanks for the report and for condensing the reproducible example. Confirming I can reproduce the panic with `rustfmt 1.5.2-nightly (a3b2bfc2 2023-04-01)`

Adding an attribute to an `unsafe` block changes its formatting

A similar issue has popped up in other cases too. #5901 and #5662 immediately come to mind, but there might be others in the backlog. I haven't looked into this,...

Adding an attribute to an `unsafe` block changes its formatting

I'm assuming this affects all blocks, not just unsafe blocks? What about async blocks for example?

Adding an attribute to an `unsafe` block changes its formatting

I think its the same underlying problem as #5662, but it's occurring in a different parts of the codebase. rustfmt rewrites attrs before rewriting the AST node those attrs are...

Adding an attribute to an `unsafe` block changes its formatting

I did a little more digging into this one. I don't know if this is actually a bug, and I'm no longer convinced this is related to https://github.com/rust-lang/rustfmt/issues/5662. It seems...