Yacin Tmimi

@davidtwco I'm assuming this might have been caused by sharing the `SilentEmitter` between rustc and rustfmt in https://github.com/rust-lang/rust/pull/121301. I believe this is coming up because [rustc's `SilentEmitter` is defined to...

I just tested with the `nightly-2024-03-25` toolchain (`rustfmt 1.7.0-nightly (0824b300 2024-03-24`)) and this issue should be resolved. @feds01 when you have a moment could you also confirm this: Steps to...

Before closing this issue I think it would be great if we could add a test case to prevent a regression

@feds01 In this case yes. The previous behavior was for rustfmt to ignore the diagnostic message produced by the rustc parser, however there were some internal changes made in `rust-lang/rust`...

@giordan12 that's great. I appreciate you wanting to take this one one. Yes, you can add a test case in the `target` directory, and in addition to that I think...

closing now that #6232 is merged

I don't think it's necessary. It's mostly this specific case since I wanted to add a test to ensure nothing was being output to stdout and stderr. Typically a source...

Thanks for reaching out! confirming I can reproduce this using `rustfmt 1.5.2-nightly (adfdf1c5 2023-01-26)`. To fix this we can prevent flattening match arm's when rewriting macro definitions. We determine if...

@ColonelThirtyTwo thanks for the follow up. rustfmt doesn't use the token specifiers to inform how it'll reformat the code. I think to be safe we shouldn't try to remove the...

@raheja15 I'd encourage you to take a look at a different issue since @calebcartwright mentioned wanting to make sure that any changes we make here adhere to the style guide....