Yacin Tmimi comments

Results 716 comments of


                                            Yacin Tmimi

Using a markdown formatter for (doc) comments & wrapping

If these issues were resolved I'd be more open to leveraging `comrak`. As I mentioned, I've been looking into better markdown support myself, but I also want to stress that...

Using a markdown formatter for (doc) comments & wrapping

Very good point!

Using a markdown formatter for (doc) comments & wrapping

@tgross35 I got the ball rolling on this in #5909. If you've got the bandwidth and the interest to help out it would be great if you could take a...

Fix failure with line comment following `..` in a struct pattern

@mousany I haven't had a chance to review these changes yet, but I wanted to let you know that we strongly discourage merge commits. Please rebase on the latest master...

`match_arm_blocks = false` interacts poorly on some lines that are exactly `max_width + 2` long.

Thanks for the detailed report! I haven't had a chance to look into what's going on in this case, but it might be that we're failing to take the trailing...

Multi-line Fn supertraits are indented improperly

@swooster thanks for the report! You're right the indentation seems off here

Always Place Spaces after Commas in Macro Match Arms

overall I think the change looks good. I'm curios how the following is formatted: ```rust macro_rules! x { ($a:ident, $b:ident,) => {}; } ``` Do we add a space after...

Always Place Spaces after Commas in Macro Match Arms

I appreciate you looking into this for me. I just wanted to double check that was the case since it would have been unfortunate if we added a space after...

Always Place Spaces after Commas in Macro Match Arms

Thanks for including the additional test case. Before I forget, I also want to say thanks for your first contribution to rustfmt 🎉 > Since the commit for the extra...

Always Place Spaces after Commas in Macro Match Arms

> I can propose an addition to the style guideline, but honestly, I think it's better if macro formatting is always gated behind an unstable option (currently the case). They're...