Yacin Tmimi comments

Results 716 comments of


                                            Yacin Tmimi

rustfmt removes double colons in macro

Thanks for the report! Confirming I can reproduce this with `rustfmt 1.5.1-nightly (2f3ddd9f 2022-06-27)`

rustfmt removes double colons in macro

A smaller reproducible example. No macro needed. **Input** ```rust struct Runtime { Council: pallet_collective:: } ``` **Output** ```rust struct Runtime { Council: pallet_collective, } ```

rustfmt removes double colons in macro

hmm okay on second thought I think we actually want to remove the `::` if we're not in a macro context, but inside the macro we don't want to remove...

Match arm trailing whitespace triggering error; match arm lone comma before comment unformattable

Thanks for the report. I also appreciate you doing some digging to try and find related issues! I made a quick edit to add some trailing spaces to example 1,...

Fix for 4824 - multi comments cause internal error

For what it's worth, I had a similar idea of removing the leading whitespace in #5392.

Fix/Extra whitespace in nested pub extern

Seems like a networking issue. No worries, I just reran that job.

Feature: add spaces_within_parenthesized_items option.

Thanks for submitting your first PR 🎉 Could you open a feature request issue where we can discuss the motivation for this change as well as the scope of the...

In some cases rustfmt emits nothing on files with `#![cfg_attr(rustfmt, rustfmt_skip)]` when using `--emit=stdout`

Thanks for the report! Confirming I can reproduce this using the current master.

In some cases rustfmt emits nothing on files with `#![cfg_attr(rustfmt, rustfmt_skip)]` when using `--emit=stdout`

@calebcartwright using the current master 38659ec6ad5f341cf8eb3139725bf695872c6de7 Here are some steps you can take to reproduce: 1) Confirm the commit hash: `git log -1 --pretty=format:"%h"`. I get 38659ec6 2) write the...

In some cases rustfmt emits nothing on files with `#![cfg_attr(rustfmt, rustfmt_skip)]` when using `--emit=stdout`

I believe the issue can be tracked down to the call to `filter()` when constructing the `files` iterator. We skip the file while constructing the iterator so we never actually...