Yacin Tmimi
Yacin Tmimi
@arifd Thanks for providing another example. I think the `error[internal]: left behind trailing whitespace` you're getting is unrelated to the original issue. Your error is unrelated to `wrap_comments=true` as I...
> As such I'm curious where you see the benefits of this coming into play, I presume system tests being the only relevant target. Is it perhaps related to ergonomics...
I also want to acknowledge that I've seen this and say that I'll try to carve out some time next week to start a review
> For the calling path and tests, do we plan to keep working on this PR or get it merged first? I think I'd be fine either way, but it...
Hey @xxchan Thanks again for your work on getting this started. I know you mentioned that you were a little busy https://github.com/rust-lang/rustfmt/issues/4091#issuecomment-1083603647, so I went ahead and rebased your changes...
Just want to elaborate a little more on the issue that we're experiencing here, and why I think this is the approach we should take. For reference here's the code...
> could you add some test cases that have imports nested a few levels (e.g. imports within some in-line mod or other item) @calebcartwright I added the test cases you...
Thanks for linking those related issues. I went ahead and read the threads and added test cases for each linked issue. I also added a test case with some more...
To be honest, I was just as surprised when I started working on this. Fingers crossed the `Tall` case isn't too tricky to get right, and doesn't add too much...
Alright, I think i've got it working as intended. There might be some edge cases I'm not thinking about though. I believe the weird formatting we saw in the `Tall`...