Yacin Tmimi
Yacin Tmimi
>I'm content deferring this to a follow up, but want to make sure we've got test cases that include combinations with other (potentially) relevant config options, like indent_style, hard_tabs, etc....
> Tangential, but we should really name fn_args_layout to something like fn_params_layout. Since this option has already been stabilized we'd have to be able to support a soft deprecate an...
@calebcartwright #5387 is the follow up PR that renames `fn_args_layout`.
> Oh, and not necessary but may want to consider adding an entry for this to the changelog to save ourselves some work down the road 😅 Great idea. I'll...
That's all totally reasonable! I'd definitely be up for helping out with the testing! Would testing be as simple as cloning each repo we want to test and then run...
Great! If you have a set list of repo's we should include in testing please let me know, otherwise I'll just poke around the `r-l` repo, and other large rust...
Thanks for pointing me in the right direction. I'll report back once I've done some testing!👨🔬
Planning to run through some other repos, but just want to walk through the steps I took: 1) compiled a release binary for the `fn_call_args` version of rustfmt and copied...
hmm I feel like going with a new option to handle the current behavior seems like the best approach to me. Maybe going with something like `Inferred` or `Computed` to...
> Perhaps there's a phrase we could derive from the behavior currently prescribed by the Style Guide? Here's what the style guide has to say about [function calls](https://github.com/rust-dev-tools/fmt-rfcs/blob/master/guide/expressions.md#function-calls), and [function...