Yacin Tmimi

Results 716 comments of Yacin Tmimi

@Jules-Bertholet @workingjubilee Do either of you know if there are crates that already implement the normalization?

@Jules-Bertholet Ahhh nice! Very good to know that something like this already exists. Thanks for the link. > However, it seems plausible that this may cause issues if the identifiers...

Thank you both for the confirmation. In that case, I think we could add an opt-in configuration option to normalize idents. I'm pretty sure all idents get rewritten in `rewrite_ident`:...

@saffaffi the Issues with `?` and `%` are the same. rustfmt can only format a macro calls if it's able to parse their arguments as valid rust syntax. The `?x`...

@dhardy thanks for taking the time to look into this. Could you provide some code snippets that can be used as test cases? > Shouldn't new options be off by...

> but it seems rustfmt is in a bit of a purgatory at the moment. Could you expand on this statement? If you're implying that rustfmt isn't being maintained, then...

@trevyn thanks for the response. I can sort of see where you're coming from, but the PRs don't tell the whole story. There's a lot of work going on outside...

@pan93412 thanks again for your help on this one. This fixes a few issues so I'm going to merge. [Diff check job ran successfully ✅](https://github.com/rust-lang/rustfmt/actions/runs/6147415516/job/16678866170)

@tgross35 I believe the current formatting is correct based on the [Nested import rules defined in the style guide](https://github.com/rust-lang/style-team/blob/master/guide/items.md#nested-imports)

> Though I'm not sure why "Horizontal" breaks into a multiline group when it's not close to line length @tgross35 [From the style guide](https://github.com/rust-lang/style-team/blob/master/guide/items.md#nested-imports:~:text=If%20there%20are%20any%20nested%20imports%20in%20a%20list%20import%2C%20then%20use%20the%20multi%2Dline%20form%2C%20even%20if%20the%20import%20fits%20on%20one%20line.): "If there are any nested imports...