Yacin Tmimi
Yacin Tmimi
The backport was completed by https://github.com/rust-lang/rustfmt/pull/5853
@matthiaskrgr Do you mean this is fixed on nightly (in rust-lang/rust) or fixed on the latest rustfmt (21f353a)?
Thanks for clarifying. For reference, what version of rustfmt did you test?
@SUPERCILEX apologies for the delay. I think we're going to hold off on this one for right now. As mentioned in https://github.com/rust-lang/rustfmt/pull/5120#issuecomment-1027493392 we still need to determine which approach we'll...
> !!! REQUIRES DEBUG ASSERTIONS !!! @matthiaskrgr what version of rustfmt were you using and how can this be reproduced?
Thanks for the info! I haven't had a chance to see why this is failing, but for now here's the location of where the issue is: https://github.com/rust-lang/rustfmt/blob/ead0fc9529ef787bc0e3f7f1b92dccd00cf45915/src/formatting.rs#L227-L232
@Dangerised sorry to hear that you're having issues. Some additional information would be very helpful. Most importantly we'll need a test case that can be used to reproduce the issue....
I see, thanks for clarifying. Marking this as a feature request
Hey @joshtriplett, I've spent some time working on getting this implemented in rustfmt (rust-lang/rustfmt#5191). The guidelines you wrote up were a great help. I also found the [asm section of...
A few more operand related test cases that I wanted to get your opinion on: In this case we have an ``inout`` that doesn't fit on the same line, but...