Yoshi Tashiro (Quartile)
Yoshi Tashiro (Quartile)
Since `self.options.partner_id` is just an integer, the code should be like below: ``` python @mapping def user_id(self, record): """ Assign the salesperson of the partner if any """ partner_rec =...
@AungKoKoLin1997 Please add tests as well.
@AungKoKoLin1997 Please add an explanation on the limitation on extending the create method.
> I think this module already exists. Why don't you migrate this one? --> https://github.com/OCA/social/tree/14.0/mail_restrict_send_button @HaraldPanten The implementation of this module looks quite complicated and I imagine it to be...
@AungKoKoLin1997 Can you please forward-port this to 17.0?
We have this refactoring PR https://github.com/OCA/reporting-engine/pull/864 for 16.0 which will affect this PR if accepted. Would be nice if we could get comments on the refactoring PR.
@AungKoKoLin1997 Can you please add tests to `report_format_option`?
@HviorForgeFlow Indeed, #857 intends to supersede this PR if it works out nicely. We just haven't gotten around to do a review on that PR, which we will follow up...
@pedrobaeza The module name comes from manipulating with `field_options` arg in `_get_field()`, so it makes sense to me (similar to the tone of web_m2x_options). But we are open to change...
This PR supersedes #1908