Yoshi Tashiro (Quartile)
Yoshi Tashiro (Quartile)
@mav-adhoc There is #1957 already. Would you review this instead?
@mav-adhoc Thanks for explaining. We currently don't use this module so we may not be doing a thorough review, but I'd suggest splitting the new feature into a separate commit...
> can @yostashiro merge it? Sorry, I don't have the authority to do so. @ivantodorovich I'm not sure what the issue was in https://github.com/OCA/partner-contact/pull/1712#issuecomment-2119324522, but could you perhaps rebase so...
@AungKoKoLin1997 Please also apply a temporary fix to the test with a link to the reported issue in odoo/odoo.
> @AungKoKoLin1997 From a usability perspective I think that it would be much better to add a setting in res.config.settings to enable / disable it, and document it in the...
Thank you. @AungKoKoLin1997 Can you please follow up to add a configuration?
@AungKoKoLin1997 Can you please rebase?
@AungKoKoLin1997 Please squash commits and add more to the commit message, explaining that the current implementation breaks if used together with the mrp module.
Related: https://github.com/OCA/stock-logistics-workflow/pull/1284 https://github.com/OCA/manufacture/pull/1025
> So migration of this module to 16.0 was probably an omission. So this PR is useless as well probably. @Rad0van It should still be good to keep the module...