reporting-engine icon indicating copy to clipboard operation
reporting-engine copied to clipboard

[16.0][REF][ADD] report_csv, report_format_option

Open AungKoKoLin1997 opened this issue 2 years ago • 2 comments

This PR refactors the encoding part of the report_csv module into a new module to enable the use of encoding features across multiple reporting modules by adding this new module as a dependency.

@qrtl QT4120

AungKoKoLin1997 avatar Mar 28 '24 01:03 AungKoKoLin1997

@AungKoKoLin1997 Can you please add tests to report_format_option?

yostashiro avatar Apr 02 '24 03:04 yostashiro

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Apr 04 '24 02:04 OCA-git-bot

Question @pedrobaeza How should we merge this PR? Seems that report_csv needs some major version bump while the new module does not.

HviorForgeFlow avatar May 27 '24 09:05 HviorForgeFlow

Sad this PR was closed because report_format_option is a really good idea. But yes report_csv shouldn't depends on it for now @AungKoKoLin1997 @yostashiro @HviorForgeFlow @pedrobaeza

bealdav avatar May 31 '24 18:05 bealdav

@bealdav I created new PR only for report_format_option but I renamed the module name and fields name to avoid the UI breakout because of having same fields name in both report_csv and report_text_format_option. https://github.com/OCA/reporting-engine/pull/884

AungKoKoLin1997 avatar Jun 03 '24 01:06 AungKoKoLin1997