reporting-engine icon indicating copy to clipboard operation
reporting-engine copied to clipboard

[16.0][ADD] report_qweb_decimal_precision

Open yostashiro opened this issue 1 year ago • 5 comments

This module allows administrators to define the decimal precision of float fields for QWeb report presentation.

Functionality wise, this basically replaces https://github.com/OCA/reporting-engine/tree/16.0/report_qweb_decimal_place.

~Tests need to be added.~

Configuration: image

Result: image

@qrtl

yostashiro avatar Jan 13 '24 14:01 yostashiro

It worked as expected. Functional tests were performed.(purchase.order.line/sale.order.line/account.move.line)

liuhehe1995 avatar Feb 19 '24 10:02 liuhehe1995

Hello @yostashiro and @AungKoKoLin1997 I can see that both module that you are proposing share similar functionalities. Should I merge this or should we go for https://github.com/OCA/reporting-engine/pull/857?

I can see that report_qwebt_field_converter is kind of more generic feature.

Feedback welcome

CC @OCA/reporting-engine-maintainers

HviorForgeFlow avatar Mar 19 '24 09:03 HviorForgeFlow

@HviorForgeFlow Indeed, #857 intends to supersede this PR if it works out nicely. We just haven't gotten around to do a review on that PR, which we will follow up in the coming days.

yostashiro avatar Mar 19 '24 09:03 yostashiro

Ok thanks for your quick feedback, maybe this PR can be closed then.

HviorForgeFlow avatar Mar 19 '24 09:03 HviorForgeFlow

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 21 '24 12:07 github-actions[bot]