reporting-engine icon indicating copy to clipboard operation
reporting-engine copied to clipboard

[16.0][ADD] report_qweb_field_converter

Open AungKoKoLin1997 opened this issue 1 year ago • 1 comments

Related: https://github.com/OCA/reporting-engine/pull/842

@qrtl

AungKoKoLin1997 avatar Feb 26 '24 08:02 AungKoKoLin1997

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 29 '24 12:09 github-actions[bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Mar 13 '25 03:03 OCA-git-bot

We should avoid plurals in module names.

pedrobaeza avatar Mar 13 '25 07:03 pedrobaeza

@pedrobaeza The module name comes from manipulating with field_options arg in _get_field(), so it makes sense to me (similar to the tone of web_m2x_options). But we are open to change the module name if that's better for the community.

yostashiro avatar Mar 13 '25 07:03 yostashiro

Yeah, web_m2x_options is a legacy name that comes from very old before setting this guideline. The guideline is set for avoiding constant typos when you start doing derivative modules, as the s in the middle of the module name is very confusing. Example report_qweb_field_options_whatever, that you mispell easily as report_qweb_fields_option_whatever, report_qweb_fields_options_whatever, etc.

pedrobaeza avatar Mar 13 '25 07:03 pedrobaeza

I changed the module name.

AungKoKoLin1997 avatar Mar 13 '25 08:03 AungKoKoLin1997

/ocabot merge nobump

pedrobaeza avatar Mar 13 '25 08:03 pedrobaeza

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-857-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Mar 13 '25 08:03 OCA-git-bot

Congratulations, your PR was merged at fd1574c245616ff2b16351ce49694a662e318943. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Mar 13 '25 08:03 OCA-git-bot