Yaacov Rydzinski

Results 309 comments of Yaacov Rydzinski

@darkbasic Not sure if it helps, but I removed explicit inclusion of dom in v8.6.1, can you let me know? Otherwise can you set up a reproducing repository?

I guess I am just confused (as usual) why do you as package user need to add dom, but in package itself, all functionality and tests compile with tsc without...

@darkbasic I am going to close this for now as I can't reproduce. I like to keep the issues section super responsive in terms of bugs. Feel free to reopen...

Reproduced! The requirement to include dom for the library was hidden by outdated inclusion of @types/supertest in package.json.

My fix will be as above to outsource the link as possible.

Way forward on this is via merging of https://github.com/jaydenseric/apollo-upload-client/pull/179 See https://github.com/yaacovCR/graphql-tools-fork/commit/2d7482facfe44e5cf13a7bff811fe877462ca03b

what about if we simplify to original behavior, but wrapped in a try/catch block a la ```ts function isProduction(): boolean { try { return process.env.NODE_ENV === 'production'; } catch {...

> It's not just the bundle size - that check is placed in probably the hottest code path of the whole package (and as it is, it unfortunately only makes...

> * [xstate.esm.js](https://unpkg.com/browse/[email protected]/dist/xstate.esm.js) is an ESM module. It will be picked up by bundlers for both `import` and `require` - they don't care. > * [xstate.cjs.js](https://unpkg.com/browse/[email protected]/dist/xstate.cjs.js) is a CommonJS module...