Yaacov Rydzinski

Results 309 comments of Yaacov Rydzinski

Updating code site: https://github.com/graphql/graphql-js/blob/76e47fcd7d432f515d5bb99e95af1851148a0c54/src/execution/values.ts#L186-L202 @IvanGoncharov et al -- Can this be considered for v17?

Actually, I think this case should not exist, and was due to improper use of getArgumentValues in client code within graphql-tools that has since been fixed. Perhaps the code could...

https://github.com/graphql/graphql-js/pull/3811#discussion_r1097258865

A changelog entry for the first 2 changes in the PR stack might read as follows: ** Implements spec changes around the introduction of the Schema Coordinate nomenclature. - Introduces...

relevant: https://github.com/graphql/graphql-js/issues/3858 (perhaps especially https://github.com/graphql/graphql-js/issues/3858#issuecomment-1458786732) and https://github.com/graphql/graphql-js/pull/3859 This was discussed this at [a WG meeting](https://github.com/graphql/graphql-wg/blob/main/agendas/2023/06-Jun/01-wg-primary.md) (i do not see notes for that meeting) As far as I recall: The consensus...

Tagging @abhinand-c explicitly.

Closing this for now, requires measurement to determine benefit before reopening.

I think you are right, this was to support the createServerHttpLink for supporting graphql uploads. I was planning on splitting that off to a separate repo at some point. How...