Yaacov Rydzinski

Results 309 comments of Yaacov Rydzinski

Graphql tools has a mapSchema function that seems similar

See https://www.graphql-tools.com/docs/schema-directives#full-mapschema-api for further discussion, you can scroll up for some examples. code is freely available via MIT license I believe to integrate upstream or just for comparison approach

Although my personal thought is that in terms of priorities, this has been handled in the package ecosystem and we should focus more in graphql JS on enabling custom execution...

@IvanGoncharov i guess the method of providing this hook may depend on the upcoming js-wg discussion

Per Google Translate, which doesn't seem like an exact match: >First of all, thank you very much for opening up such a good project for developers to use, and secondly,...

I think this is great! would suggest option name to be enableSuggestions with default of true, perhaps might eventually default to false see https://github.com/graphql/graphql-js/issues/2247 in that issue, consensus seems to...

There are also some didYouMean calls in enum parseLiteral, I think we can add an execution option (in parallel to the one in validate) that then has to be passed...

https://github.com/graphql/graphql-spec/pull/939#issuecomment-1092282972

> Should queries be allowed to select fields directly on the union now that the union definitely implements the field? > > Some exploration within the reference implementation yielded that...

*Decision Record* We decided [at the last WG](https://github.com/graphql/graphql-wg/blob/main/agendas/2022/2022-05-05.md) that if unions implement interfaces, then they have directly querable fields. This PR and [the spec PR](https://github.com/graphql/graphql-spec/pull/939) have been updated with the...