opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

Add support for `mysql-connector-python` v9

Open omikader opened this issue 1 year ago • 1 comments
trafficstars

What problem do you want to solve?

The mysql-connector-python package had a major version bump on July 1, 2024. However, the opentelemetry-instrumentation-mysql plugin only supports 8.x

Describe the solution you'd like

It would be great if opentelemetry-instrumentation-mysql worked for mysql-connector-python >= 8.0 vs ~= 8.0

Describe alternatives you've considered

It is worth noting that the 9.0.0 changelog for mysql-connector-python includes opentelemetry support, but I prefer to have the auto-instrumentation capabilities provided by this library as opposed to explicitly/manually instrumenting MySQL connections.

Additional Context

I did a quick pass and I don't think their API had any breaking changes so I think it might be as easy as just relaxing the version constraints and trying it out. Happy to open a PR if it's actually that easy 😅

Would you like to implement a fix?

Yes

omikader avatar Jul 17 '24 20:07 omikader