opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard
verified publisher icon open-telemetry

Import the GCP resource detector class

Open DylanRussell opened this issue 1 year ago • 4 comments

Description

Import a resource detector class for GCP. This change doesn't add any new code. It's re-exporting a package that is in the downstream GCP repo. This lets the GCP resource detector be loaded in via the "opentelemetry_resource_detector" entrypoint used here

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [X ] This change requires a documentation update

How Has This Been Tested?

n/a

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [ X] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [ X] Followed the style guidelines of this project
  • [ X] Changelogs have been updated
  • [X ] Unit tests have been added
  • [X ] Documentation has been updated

DylanRussell avatar Mar 05 '25 20:03 DylanRussell

CLA Not Signed

linux-foundation-easycla[bot] avatar Mar 05 '25 20:03 linux-foundation-easycla[bot]

Why are we taking the burden of maintaining an empty package upstream just for a re-export? Why not defining the entry point in your package so that people interested can just use it? I'm a user of the gcp resource detector and defining the entry point myself in my package.

xrmx avatar Mar 06 '25 10:03 xrmx

Yeah that is a good question. The other langugage contrib repo's have the GCP resource detector class, and it's weird that this one doesn't. I think putting it here makes it more discoverable.

I'm not sure how the versioning of this package would work.. Do we just keep the version forever pinned at 0.1 ? Do we have to bump the version everytime we bump the alias ? Keeping the 2 in sync is annoying

DylanRussell avatar Mar 06 '25 15:03 DylanRussell

I'm not sure how the versioning of this package would work.. Do we just keep the version forever pinned at 0.1 ? Do we have to bump the version everytime we bump the alias ? Keeping the 2 in sync is annoying

We can release packages independently and put whatever versions you want

xrmx avatar Mar 06 '25 16:03 xrmx