William Allen

Results 174 comments of William Allen

Oh yeah, oops. I updated my suggestion.

Since you are making a UI change, would it be possible to add before/after screenshots to the PR description so it is easier to tell what this PR added if...

The code looks good to me but I will leave the full review of the backend code+overall feature review to someone more qualified.

This appears to be the same bug https://github.com/Submitty/Submitty/pull/7610 was attempting to fix. https://github.com/Submitty/Submitty/pull/8395 was proposed as a temporary mitigation (to simply comment out the relevant code) but this should be...

Hi @skara9, thanks for this contribution! Can you maybe fill out the pull request body a little more? In particular, it would be good to add some information about what...

Hi @kevinochoa8266! Submitty welcomes contributions from anyone. If you'd like to tackle this issue, go right ahead! Once you make a pull request, it will undergo a review, and hopefully...

I believe that Grade Inquiries also share this inconsistency, except that they only use the first name/first preferred name. For example, here is a snippet of one of my recent...

These changes look somewhat better. I recommend using WAVE (see [here](https://submitty.org/developer/software_and_system_design/web_accessibility#examine-your-interface-design-with-wave) for more info) to make sure the contrast in dark mode and light mode is ok.

Are there any errors in the logs?

> No. Well, at least not in the docker logs for cdash and cdash_postgres. The relevant logs are in `/cdash/storage/logs` if you're using our default Docker image.