William Allen

Results 174 comments of William Allen

I don't see anything out of the ordinary in the file you provided, but @zackgalbreath probably knows this part of the codebase better than I do. Things that might be...

Can you add a screenshot of the new feature in light mode to the PR description for documentation purposes?

Can you please add before/after screenshots directly to the PR description? The PR description is the long-term documentation of this change, and we want people to be able to understand...

The video in your PR description appears to be broken. Can you add some before/after screenshots instead?

@cjreed121 Can you do a security review on this one whenever you get the chance?

Great suggestion! There are a few things coming down the pipeline such as the new GraphQL API which should make this easier to implement. I think it would be a...

It's worth noting that some tables like the banner table contain "global" rows (using the project ID 0, for example), which makes it more difficult than it initially appears. Great...

@IDzyre It looks like the tests are failing due to a flaky test which has since been fixed on main. Updating this from main should revolve the issue.

This PR still seems to need some work, with multiple failing tests. Is there anything in particular you're looking for in a review here?