William Allen
William Allen
This PR appears to be a duplicate of https://github.com/Submitty/Submitty/pull/10206, which is much more complete than this PR.
The video in the PR description seems to be broken. Screenshots would probably be good enough in this case. Can you please add some before/after screenshots instead of the video?
@ziesski Should this PR be marked as a draft?
Can you please add before and after screenshots to the PR description? Feel free to add this back to the maintainer review queue after doing so.
> Added before and after screenshots just now. Can you also include screen shots in light mode?
It looks like PHPStan is failing. You can follow @DarthNyan's suggestion above to resolve the issue.
It looks like PHPStan is failing because you renamed a parameter. You can resolve the error by either fixing it, or [regenerating](https://submitty.org/developer/testing/linting_static_analysis#php-static-analysis) the baseline.
@hansongu123 A bunch of changes have been made since your approval in February. Can you take another look at this sometime to make sure everything still works as expected?
I changed the status to "Awaiting Maintainer Review", but I made significant edits to this PR and am not particularly familiar with pylint, so it would be good for another...
It looks like you have conflicts that need to be resolved, as well as some PHPStan issues. In addition to resolving these two things, can you also add links to...