William Allen

Results 174 comments of William Allen

@micpap25 It looks like there are more merge conflicts now...

@zacharymnp It looks like a selector needs to be updated in the polls test. This should be good to go once that's done.

@ethanfordwork Can you please fill in the PR description? The PR description should provide at least a summary of the changes being made, a brief motivation for why the changes...

Perhaps another maintainer will comment with a different opinion, but I'd prefer to see the tests in this PR. By demonstrating that these changes work via a test, we can...

I guess if there are two separate people working on it, I think it's fine to keep the two PRs separate so everyone gets the appropriate credit, and I'll take...

I like the general direction the new design is going. It feels like further refinements could be made, but I'm struggling to come up with a cleaner design. Perhaps @bmcutler...

Please fill out the PR description with information about the changes you made, and why you made them. Failure to do so will result in the PR being closed.

@ZheyuDeng This PR has conflicts now.

After discussion, we've decided that the approach taken in https://github.com/Submitty/Submitty/pull/10470 is the best approach.

The documentation is probably not the first place people are going to look when they are confused about the UI. I think it would be better to add some sort...