wernerdaehn

Results 13 comments of wernerdaehn

You have a root record calls Node. It has a field called left of the same type, hence the field datatype changed to long. Same for the field right. And...

Better explanation: Whenever a child (=left Node; right Node in your example) has the same datatype as a parent, the child holds the instance pointer and the actual data is...

This is normal. There are multiple ways how you can provide libraries in UI5, library-preload.js, library-preload.json are tow of them. If both would be set that would be redundant. Having...

Just one additional thought: Although olingo as a library can be used, you do not have to. The user provides a oData URL and the result is data in an...

* **the methods public String `toString()` and `public String toString(StringBuilder, Value)` imply they do something similar, but actually don't:** Correct. But as both methods do not make sense by themselves,...

(And I never said that all my contributions are flawless without a doubt. It is also my first contribution to Avro, hence I have no feel for it yet)

@unchuckable Hi Martin, I made the agreed changes and more of what you have requested initially. For example the hashCode(), the toString(StringBuffer) etc. Will check in the code as soon...

@RyanSkraba Ready for review! Just for a side note, I have some more code that I could contribute to Avro. But before doing that, I need to know if this...

Thanks @RyanSkraba, appreciate it. The important part to keep in mind is that using this interface is optional. It neither impacts existing Logical Data Types nor custom data types -...

A quick response: Agree with all you said. We need to make some decisions but whatever you decide, I am fine with.