Moshe Weitzman

Results 474 comments of Moshe Weitzman

You should emit events using event_dispatcher from the container. Then you write listeners to react to those events. See https://github.com/drush-ops/drush/blob/3d4bf9c74dcf94041dbcd82882ead6cdacc30245/src/Commands/sql/sanitize/SanitizeCommand.php#L55-L57. Also there is an example in CacheClearCommand

I have passed around $input->getOptions() in places where I used to pass around $options. If you dont want to pass around a DrushStyle and don't want to keep creating it,...

After some more thought, I like the `IoTrait` idea. Feel free to make one that all commands can use. $this->setIO() should return the DrushStyle object in the fluent style so...

See https://drupal.slack.com/archives/C223PR743/p1727296167454149?thread_ts=1727266962.922249&cid=C223PR743

> But maybe add a caveat that for the Drupal versions lower 11.1.0, we need to use the older image. Sounds like a use case for a composer `conflict` statement

Looks like the tests are hanging, like they have in all previous effots. i dont know why. See https://github.com/ddev/ddev-selenium-standalone-chrome/pull/42

I am trying a bump to Drupal 11 during testing in #58. Would be nice if I could get push permission to `bserem:patch-2` instead.

Nice work! I'm fine with releasing a new major version without that bridge, if you prefer. Also a mention in the README would be helpful.

Its a bummer that ddev add-ons dont have something like composer `conflict` statements. We have no way to prevent D10 sites from upgrading. Still, I think your plan is reasonable....

That works. In the error message, lets help the user build an `add-on get` command that will work. I hope we didn't make a mistake by making this project a...