Moshe Weitzman

Results 474 comments of Moshe Weitzman

As you know, we already support plain Symfony Console commands. The core Drush commands wont likely become those because they are woefully inadequate compared to Drush commands. For example, they...

I made a tiny console app which explored a lot off the ideas mentioned here. Feedback welcome https://github.com/weitzman/console-example > I'd like Drush commands to be plain Symfony console commands. Thats...

I'm undecided about moving FormatterTrait and the related Attributes. I do agree that both are coupled and probably should live together. When authoring a command, its helpful for all Attributes...

OK, when this PR is ready to go in, lets move the FormatterTrait and format Attributes, and Drush may thinly extend the Attributes.

1. The output formatter system is opt-in. Commands who dont care can ignore it. 2. The doExecute and getFormatterOptions() are a bit of a dance, I agree. I'm open to...

The key bits that only the command knows the values for stuff like DefaultTableFields, FieldLabels, etc. Everything else is machinery. > I am also wondering if formatter options can somehow...

I posted a status update to the issue description here. It says > This PR is on long term hold. Since Drush is already bundled with Drupal CMS, most newcomers...

Symfony Console recently released 7.3 which includes https://github.com/symfony/symfony/pull/59340 ([blog post](https://symfony.com/blog/new-in-symfony-7-3-invokable-commands-and-input-attributes)). This PR should probably be adjusted accordingly. Thoughts are welcome.

IMO its a bit too much code to maintain. I'd just as soon stick with current docs approach. Happy to discuss more.

That command sounds useful. I would weigh its usefulness against the maint burden of it. I'm not sure how to decision would end up. https://github.com/ddev/ddev-drupal-contrib?tab=readme-ov-file#changing-the-drupal-core-version describes the current steps and...