Moshe Weitzman comments

Results 472 comments of


                                            Moshe Weitzman

Provide an option to lock on a specific version of scripts used from Gitlab templates

Sounds good ... For clarity, we default to the most recent published release, not "latest changes" or "cutting edge".

Could not start a new session. No nodes support the capabilities in the request

Those tests are now fixed. I dont think they were related to your issue but you could fetch rc2 and see.

Make the url logged in field:create a clickable link

Yes I think we can adjust the expectation or remove it - whatever you think.

Use the search input for select lists with lots of options

IMO, the search UX is more cluttered than the select UX. Lets only use search when we expect 20 or more options. So that rules out cache:clear among others.

Use the search input for select lists with lots of options

Could we create a wrapper prompts that automatically switch between select/search and multiselect/multisearch. i kinda think that we should use 20 as the threshold and we experiment with showing 20...

Allow override language_default->language on command execution

If anyone takes this on, please start with Drupal 8 and support prior versions if you have time and need.

Drush ErrorHandler intercepts trigger_error events, preventing external loggers (e.g. Sentry/Raven) from capturing them

Help is appreciated here. Any PR should be against 14.x branch. Thanks.

Ensure the order of database updates shown is consistent with how it would actually run

I notice that this is in Draft. Please remove draft whenever this is ready for review. No rush. Thanks.

Ensure the order of database updates shown is consistent with how it would actually run

This looks like an excellent improvement Thanks for the tests. Alas, this PR has to go into 14.x as well and there have been a few changes there (symfony console...

Guard against missing PDO MySQL constants

Whats your PHP version?