Moshe Weitzman
Moshe Weitzman
We added a `drush core-version` command. I think our current setup intructions do the job.
LGTM. I'll wait a day for feedback. Any chance you can chime in at https://github.com/drush-ops/drush/issues/6137?
@claudiu-cristea - that looks like xdebug extension is not enabled in DDEV. Thats a prerequisite for using --xdebug.
Its been a long time, but i think I solved this via a composer.json autoload entry - https://gitlab.com/weitzman/drush-oracle-driver
Can't the custom driver create its own class that extends SqlSqlite and override the `dumpCmd` or dumpProgram() method?. This is what SqlMariaDb does - https://github.com/drush-ops/drush/blob/13.x/src/Sql/SqlMariaDB.php
Your custom driver can do stuff before or after a call to parent::dumpCmd(), for example. It can be super thin like that mariadb driver is. Sorry, I'm not really following...
I'm afraid we disagree. Extension via OO is a core principle we can and should rely on. Also, there is no boilerplate in the custom class. It just contains the...
> I'm wondering if we shouldn't throw an exception instead of returning NULL here Yes, but would need to be a new major version of Drush since its an API...
LGTM. Lets see if anyone else has thoughts ... Please remove from draft when you are satisfied.
LGTM. I have done it in a while, but I want to make sure our tests can still pass locally. Could you please check that and document at the bottom...