Results 276 comments of Johannes Weiss

I think this sounds reasonable and we will need something like this accessible from SwiftNIO. As described above, I think we want the following properties: - one baggage context per...

> Agreed on all of the above :-) Indeed should not be too much work; and a Draft PR likely good. Yeah, just gives us something concrete to discuss. >...

commit was ``` commit 3e49ea0b7c16ee0e0985babff9659d467d4f59fd (HEAD -> master, origin/master, origin/HEAD) Author: Trevör Date: Thu Apr 25 22:26:08 2019 +0200 ```

@tanner0101 this is still unfixed: ``` Test Case '-[HTTPKitTests.HTTPClientTests testClientDefaultConfig]' passed (1.599 seconds). Test Case '-[HTTPKitTests.HTTPClientTests testClientProxyPlaintext]' started. :0: error: -[HTTPKitTests.HTTPClientTests testClientProxyPlaintext] : failed: caught error: The operation couldn’t be...

@0xTim thank you! but this will also affect all user code, right? Is it necessary that Vapor parses the command line in these scenarios in unit test? Ie in `.testing`?

> Ah right, see what you mean now. Yes there's definitely something going on when you create an `Application` and execute it from the command line. I'm not sure if...

These issues can manifest as arbitrary memory unsafety and therefore security vulnerabilities. I would very very much recommend fixing them asap. Thread unsafety in Swift is especially troublesome because it...

@spookytime what about Thread Sanitizer or Address Sanitizer?

@spookytime hmm, maybe try Thread Sanitizer?