Results 276 comments of Johannes Weiss

> It doesn't scale well. Why is `TLSConfiguration` now an argument but the rest of the `HTTPClient.Configuration` not? I think the your proposed solution in #392 is the way forward...

Yes, doing something with the keys is also important. We definitely need to document what we do here (there's a logging design doc already in this repo) and make it...

> I wonder if scrambling in a LogHandler or making logging keys configurable in every library is better. Like if every log key becomes optional with some sane default values...

Much easier once https://github.com/apple/swift-nio/issues/2447 is done (e.g. by getting https://github.com/apple/swift-nio/issues/2475 in)

> @weissi, okay, here's the plan: > > 1. I'll temporarily switch to `natikgadzhi:feature/byte-buffer-hexdump` branch for `SwiftNIO` in `Package.swift` so I can use `hexDump` > 2. I'll replace `buffer.debugDescription` with...

> What I learned today is that the default `struct` and `enum` string representation will use the `debugDescription` of any properties/associated types if available. Therefore the `debugDescription` of `ByteBuffer` is...

Technically it's API breaking because if you have ``` func foo(_ x: @autoclosure () throws -> String) rethrows { print(try x()) } func oldFoo(_ x: @autoclosure () -> String) {...

> What do you think about adding just the metadata to the task local but still threading the logger itself around. This still reduces a bunch of logger passing to...

> I have been looking at this as well for one of our services. We solved it with a log handler that allows to set the log level dynamically during...

> To expand on this a bit. We have a log handler that has a dynamic log level configuration for each file. The log handler parses the file parameter of...