Results 276 comments of Johannes Weiss

This feature seems great and your willingness to implement it is even better :-). Just some comments from my side: - Currently the left stacking point should usually not be...

they might legitimately take longer than 6 minutes but if that's the case we should make CI give us more minutes.

Cool @tomerd can we get extra CI time :)

(https://ci.swiftserver.group/job/swift-nio-ssl2-swift50-prb/196/console)

Yeah, I think hangs are a good enough signal too. There's no way we could catch _all_ things that could possibly hang so if we were to start using `XCTestExpectations`,...

Thanks @wlisac! I think there also other such APIs that we should improve on.

> The server handler can be made to stop throwing, as its only failure mode is an inability to allocate the BoringSSL object. Awesome. > The client handler is harder:...