Johannes Weiss comments

Results 276 comments of


Johannes Weiss

NIOSSL(Client|Server)Handler's init is throwing but that's not actionable

> > Couldn't we surface that as an error in the pipeline? > > In my view surfacing this as an error in the pipeline is strictly worse than forcing...

NIOSSL(Client|Server)Handler's init is throwing but that's not actionable

> Hmm, also, how does failing in the pipeline work? > > We can't fail on `handlerAdded` when the channel isn't active because it's highly likely we're being added in...

NIOSSL(Client|Server)Handler's init is throwing but that's not actionable

@Lukasa I think just adding that `static func` is good enough. Of course, we could add the `try` too but I'm not sure how many APIs (that aren't blocking) this...

NIOSSL(Client|Server)Handler's init is throwing but that's not actionable

Wow, that is surprising but good :). Did the API breakage checker work with NIOSSL or did you check in a separate repo? @Lukasa I think that sounds like a...

NIOSSL(Client|Server)Handler's init is throwing but that's not actionable

Awesome, yeah. I need to find time to properly debug what’s wrong with conplicated C targets and breakage checker

NIOSSL(Client|Server)Handler's init is throwing but that's not actionable

@Lukasa actually, the factory should be a `make*`

create a new module(?) that allows to use the universal bootstrap easily

The seed for this module could be `EventLoopGroupManager` (probably needs a better name): https://github.com/apple/swift-nio-examples/pull/48/files#diff-f7cf525c49713fc729e91d7720262e47R34

create a new module(?) that allows to use the universal bootstrap easily

CC @tanner0101 / @adam-fowler / @artemredkin / @Yasumoto who are at least some of the folks who we had suffer through repeating this code. Example: https://github.com/swift-server/async-http-client/commit/5298f20331af01d5a5ebab0dee45c032847aab55#diff-8798af428c5cad17d0051540505e9d00R76

create a new module(?) that allows to use the universal bootstrap easily

Please leave comments with stuff that you think this needs to support. The community wanted NIO anyway to provide a standard `EventLoopGroup` provider (#49) which could be solved with this...

create a new module(?) that allows to use the universal bootstrap easily

@dnadoba I think we haven't resolved a really boring issue yet: Where can this live? I think it would depend on NIO, NIOSSL, and NIOTS at least but we can't...