Weihang Lo comments

Results 766 comments of


                                            Weihang Lo

fix(datasource/crate): preserve build metadata

Closed due to there is no consensus on the solution between maintainers, and I have no time pursuing this given the error hasn't happened anymore in the rust-lang/cargo repository.

Tracking Issue for `update --precise` with pre-release

shows the current implementation is a bit buggy, and there are upper bound semantic issues not yet resolved. See these test cases: It is technically possible to fix them inside...

Tracking Issue for `update --precise` with pre-release

@BatmanAoD this is implemented in and there is doc link in the PR description. This PR also shows the current proposed semantic of matching pre-releases if you're interested. Mind sharing...

docs: More information on what is and isn't included by cargo package

Perhaps we need to purchase some credits from Docker? 😬 > ERROR: failed to solve: httpd:2.4-alpine: failed to resolve source metadata for docker.io/library/httpd:2.4-alpine: failed to copy: httpReadSeeker: failed open: unexpected...

docs: More information on what is and isn't included by cargo package

> We could split out a separate issue? I can have a look if you like, although as I'm not a project member I might need help with registering an...

docs: More information on what is and isn't included by cargo package

Thank you! @bors r+

Print a warning if anything other than Markdown or plain text is specified in the `readme` field

Thanks for the proposal! > This might be better detected by the clippy. Not exactly. Clippy team has expressed that Cargo-related lint should be in Cargo rather than in Clippy...

Print a warning if anything other than Markdown or plain text is specified in the `readme` field

Other alternative would like try parsing it as markdown, and warn if fail to parse. Downside: Cargo got a hard-dependency on a markdown parser.

Cache submodule into git db

@rustbot author

`cargo vendor`'ing a `git` crate that includes a `workspace` misses important files

Correctness is not always binary. In this case it is a spectrum of tradeoff. Initially, Cargo made a strong assumption that every directory containing a `Cargot.toml` is a package. Then...