Weihang Lo comments

Results 766 comments of


                                            Weihang Lo

`cargo vendor`'ing a `git` crate that includes a `workspace` misses important files

Thanks. Marked it as S-needs-info` to collect more inputs.

`cargo test --tests` also runs unit tests -- target filters are confusing

Totally agree it is confusing. People usually invoke `cargo test --help` and see it say `Test all tests`. Then guessing like _"I know cargo tests. **Tests** here must refer to...

`cargo test --tests` also runs unit tests -- target filters are confusing

> So is there even a way to ask cargo to test (or check or ...) all test targets (the things that are by default in the tests/ directory, the...

Where should `cargo verify-project` go?

This is the oldest commit I found https://github.com/rust-lang/cargo/commit/4de86d2eec82a92944245d0f269fe55907135de7 relevant. Looks like `cargo-verify-project` ought to be more useful than it is now. https://github.com/rust-lang/cargo/blob/4de86d2eec82a92944245d0f269fe55907135de7/README.md?plain=1#L32-L39

Where should `cargo verify-project` go?

Sounds good to me to align with `cargo read-manifest` as a starting point! Feel free to submit a PR.

Lock download file to avoid races

> after the uv type of the same name Would be great if you can a link to it :)

cargo add: "failed to persist temporary file: Text file busy" on vboxsf (Linux guest Windows host)

Thank you for writing down such a detailed report! By reading your trace it's very likely #12744 is the root cuase, though I currently don't have either Virtualbox or Windows...

cargo add: "failed to persist temporary file: Text file busy" on vboxsf (Linux guest Windows host)

@Revertron Could you provide more information of what platform and version you're in? Also does it not work with 1.81 either?

cargo add: "failed to persist temporary file: Text file busy" on vboxsf (Linux guest Windows host)

Are you also on Virtualbox with Windows host Linux guest?

cargo add: "failed to persist temporary file: Text file busy" on vboxsf (Linux guest Windows host)

We kinda identified the issue happening on VirtualBox with Windows host + Linux guest when using the [tempfile](https://crates.io/crates/tempfile) crate (see . I don't have the hardware and setup to root...