Weihang Lo comments

Results 766 comments of


                                            Weihang Lo

Cargo package says the repo is dirty, but the files are gitignored

> Project link, if you want to check it out for yourself: [gitlab.com/korrat/nullable-utils](https://gitlab.com/korrat/nullable-utils/) The link is broken btw

feat(template): tracks Cargo's call-for-testing label

No worries. Thanks for taking care of it!

chore(cargo-lock): bump to [email protected]

Done in [`c8b30fd` (#1205)](https://github.com/rustsec/rustsec/pull/1205/commits/c8b30fda18980cc3693cb0f3b10b59719b9fd13a). Is this what we want?

chore(cargo-lock): bump to [email protected]

It seems that `cargo-lock` and `toml` packages are referenced within the workspace multiple times, and I need to address that. It is easy to get out of sync. Would you...

chore(cargo-lock): bump to [email protected]

Ah, sorry I have been busy these days. Thanks for picking it up :)

Tracking Issue for `-Zbuild-analysis`

## Implementation tasks See the PR description.

Tracking Issue for `-Zbuild-analysis`

sudo cargo install recompile everything after cargo build --release

The fingerprint that determines a rebuild is affected by [several things]. I guess at least the version info of invoked `rustc` changed when switching to a super user, due to...

sudo cargo install recompile everything after cargo build --release

Hmm… interesting. Haven't tried out your new discovery, but I can reproduce the steps in the PR description and the example has no dependency, so these two might be different...

[beta-1.92] fix: force update mtime of cargo-check artifacts

It is fairly new so data is insufficient. If there is a concern, we should cancel this backport. Backport should not be risky.