Weihang Lo

Results 766 comments of Weihang Lo

Some more questions: * Is there any `Cargo.toml` containing odd `package.include` that refer to relative parent directory like `..`? * Is there any symlink under a member package pointing to...

Nice! The follow-up question then will be: Should paths from `rerun-if-changed` be normalized? I believe that could also resolve this issue because `.gitignore` is already respected. Note that it is...

@joshtriplett from : > I don't personally think this should be the default, because `cargo build` does catch things `cargo check` does not, per [RFC 3477](https://github.com/rust-lang/rfcs/blob/master/text/3477-cargo-check-lang-policy.md) as mentioned. > >...

@ranger-ross from : > Just pitching in my 2 cents. > I also tend to lean towards keeping `cargo build` as part `cargo publish` for the additional verification. > >...

https://github.com/rust-lang/cargo/actions/runs/15396140671/job/43317289386#step:13:4554 Network glitch? ``` > [internal] load metadata for docker.io/library/alpine:3.22: ------ Dockerfile:1 -------------------- 1 | >>> FROM alpine:3.22 2 | 3 | RUN apk add --no-cache openssh git -------------------- ERROR:...

Just fixed `!= -> !==`. `pnpm test` reported all green on local. I think it is ready to merge. Thank you

Thanks for the review! I am not sure what went wrong in the test coverage though: https://app.codecov.io/gh/renovatebot/renovate/pull/36005

Thanks. 661d18d275298807ad312a836132f6cd6c091fb4 fixes the missing branch coverage I believe.