rust-lang
Cache submodule into git db
What does this PR try to resolve?
My attempt to continue https://github.com/rust-lang/cargo/pull/10279.
This:
- Moves the code for creating git db into GitSource::update_db
- Creates GitSource for each submodules
- Replaces fetch inside update_submodule by GitSource::update_db and db.copy_to
- Removes recursive update_submodules calls cos db.copy_to already recursive.
Fixes https://github.com/rust-lang/cargo/issues/7987.
How to test and review this PR?
I tested using the original pull method:
~/.cargo/target/debug/cargo update -p boring --precise 46787b7b6909cadf81cf3a8cd9dc351c9efdfdbd
~/.cargo/target/debug/cargo update -p boring --precise c037a438f8d7b91533524570237afcfeffffe496
and confirmed that the time to do the second update is negligible. Also test if it can fetch submodule offline using the downloaded git db
git clone https://github.com/pop-os/cosmic-files && cd cosmic-files
~/.cargo/target/debug/cargo fetch --locked --target=$(rustc --print host-tuple)
rm -rf ~/.cargo/git/checkout ~/.cargo/target/debug/cargo fetch --locked --target=$(rustc --print host-tuple) --offline
r? @weihanglo
rustbot has assigned @weihanglo. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
It would help reviewers if you break this down into atomic commits. For example, by making a commit for extracting update_db, it becomes clear whether it was purely an extraction or there are also other changes.
See https://doc.crates.io/contrib/process/working-on-cargo.html#submitting-a-pull-request
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
Done, the "extract code into update_db" part is a single commit now. I think the remains part needs to be in the same commit
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
Sorry for the late response, I force-pushed the commits. About new tests, if I am not mistaking, it should be only about the git db cache, not the correctness of git repo checkouts, as it should be already covered? Currently I can't find api for manipulating the cached git db, or example about testing the git cache db
Overall looks like. Let me know if you plan to reorganize the commits, or I can do that for you. Thanks!
If you can do it, please do. Thanks!