Weihang Lo comments

Results 766 comments of


                                            Weihang Lo

Warn or document conflicts between strip and debug option

Hi, and sorry for letting you confused 🙇🏾. My initial intent is like "adding both warning and documentation looks good to me". Anyway, just like what ehuss said, the cargo...

Donating Funds to git2-rs

I observed ehuss as the major maintainer of git2-rs for the past year, and they do have personal GitHub sponsor enabled. Just FYI.

docs: add lock file section to the resolver docs

@rustbot author

Cargo will silently ignore invalid .cargo/config options

Cargo configuration is considered as a kind of environment for Cargo. That said, usually a CLI won't complain to the existence of unrecognized environment variables. However, Cargo could possibly do...

Why does cargo need to download git dependencies completely?

> What seems odd though is I didn't think we downloaded all tags and branches for a git dependency. Do you have reproduction steps? This is the `CARGO_NET_GIT_FETCH_WITH_CLI=true` case. I...

Why does cargo need to download git dependencies completely?

Besides, the `-Zgit` shallow clone feature doesn't really extend to support `CARGO_NET_GIT_FETCH_WITH_CLI=true`, and I don't remember anyone has even talked about that.

error: failed to wait on curl `Multi`

Thanks for the update! I wonder if it still happens with the latest Cargo (nightly or 1.75.0). If yes, we may leave this open until we find the root cause...

core/compiler: report executable paths for all binary crates

Converted to draft for now until we have something from #13612.

Workspace inheritance reads from wrong workspace when one is nested inside of another

I cannot reproduce it either. Guess there were something cached between the first and the second invocation. You might want to run `cargo clean` in between. The implementation of `[lints]`...

Documentation: Which files should you include in your package?

Documenting is hard. You need to put a right amount of explanation so people won't drop out in the middle of reading. The content doesn't quite fit [The exclude and...