Weihang Lo

Results 766 comments of Weihang Lo

> Work with upstream Cargo with an in-tree pacakge for lock serialization. (This is on me?) I am mostly thinking through this. The Cargo team has published a new crate...

> In the meantime it doesn't otherwise seem to have types relating specifically to Cargo.lock, only Cargo.toml. That's true. I think maybe we should just copy over from there one...

@tarcieri this is ready for review. Take your time :) Most of the code are copied or adapted from `cargo` the lib. Note that I've identified a bug not related...

Could you point out the specific tests needing this?

`--no-run` seems like a viable solution for Cargo. In an ideal world everything should be JSON under `--message-forma=json`. I don't really think `snapbox` is responsible for this misfortune.

> ### Possible Solution(s) > > Follow redirects Note that the change in #15593 not only affects `cargo search` but also [other registry related commands](https://doc.rust-lang.org/nightly/cargo/commands/publishing-commands.html). I wonder if there is...

Could you try moving all `--config` flags to before `--lib`? Edit: that might not be the issue. Was just guessing.

It is very possible a bug in host-config/target-applies-to-host. Not yet got time to look into it deeper but removing those helps.

> Is there an expected order for the flags? @GuillaumeGomez I was wonder if those `--config` were interpreted as trailing args in `cargo rustdoc` but no. If that had happened...

```console cargo +nightly rustdoc --lib --all-features --offline --verbose -j6 -Zunstable-options -Zrustdoc-map -Zhost-config -Ztarget-applies-to-host -Zrustdoc-scrape-examples --config "build.rustflags=['--cfg', 'docsrs']" --config "host.rustflags=['--cfg', 'docsrs']" --config "build.rustdocflags=['--cfg', 'docsrs', '-Z', 'unstable-options', '--output-format', 'json', '--static-root-path', '/-/rustdoc.static/', '--cap-lints',...