Weihang Lo

Results 766 comments of Weihang Lo

Other future possibilities along with this change: * We could offload linker flags from `RUSTFLAGS` to something like [RUSTLINKFLAGS](https://github.com/rust-lang/cargo/issues/4349), so that normal rlib caches have a higher chance of being...

Is it a limitation of the current implementation, or the future possibility just doesn't make sense?

Status update: currently blocked on .

I bumped into this a couple of times with nixpkgs but never remembered how I fixed it. Guess it might be nix patch-elf at sometimes patching rustc wrongly, or my...

We have JSON output support in `cargo rustdoc` BTW. The `--output-format json` needs special handling for Cargo to track files. > cargo needs rustdoc to support --print=file-names, which it doesn't...

That said, if there are other reasons Cargo wants `--print=file-names` support in rustdoc, we could do that and benefit from it.

> oh, huh, TIL. i agree this is fine and we just need to add support to cargo doc. Close as adding `cargo doc` support is tracked in #13283

@xldenis Try turn off incremental compilation for a while (`env CARGO_INCREMENTAL=0` or `build.incremental = false` in config). If with that it never happens, that may suggest it is the same...

It is more similar to these: * * Unfortunately `CARGO_ENCODED_RUSTFLAGS` doesn't not expose flags controlled by Cargo. It represents extra flags that user passes directly. Feel free to create a...

This will be a breaking change, and hard to discover even when across the edition boundary until it really published If we had a chance to change it, I would...