Weihang Lo comments

Results 766 comments of


                                            Weihang Lo

Programatic Patching

Thanks for the proposal. > Is there something that makes this impossible? > If I create a PR, which of the options below would be the desired one? Sorry I...

Unable to use workspace dependency in patch

There is one nasty difficulty of supporting this: `[patch]` can also be in Cargo configuration (`.cargo/config.toml`), and configuration has no knowledge of what workspace is. That said, it can be...

Unable to use workspace dependency in patch

> > Your package can still be able to publish to crates.io. > > How can that be? I thought crates.io crates can't have git dependencies. I rely on features...

Warning when large binary files are included into the bundle

Note that with `-Zlints` we could have a configurable lint for Cargo to emit this warning.

error: output of --print=file-names missing when learning about target-specific information from rustc when `--target` is specified

I believe https://github.com/rust-lang/cargo/pull/15036 should fix this. It will get into the main rust-lang/rust repo on Friday, so expect to see it on nightly in the weekend!

error: output of --print=file-names missing when learning about target-specific information from rustc when `--target` is specified

Oh I see now. For `--cap-lints`, the behavior for this flag is the first occurrence wins . I am unsure if we really want to and can depend on it.

error: output of --print=file-names missing when learning about target-specific information from rustc when `--target` is specified

For passing `--cap-lints` it hasn't. I got flu this week so is in a slow mode. Will ping people on Zulip asking https://github.com/rust-lang/rust/issues/54282

Tracking Issue for `--output-format` flag for `cargo rustdoc`

The unstable `--output-format` option is not yet supported in `cargo doc`. And `cargo rustdoc` doesn't support `--no-deps`. I am not sure which one you were talking about. If it is...

Cargo run is failing with "failed to set hostkey preference: The requested method(s) are not currently supported; class=Ssh"

Might be related https://github.com/libgit2/libgit2/issues/6612

Cargo run is failing with "failed to set hostkey preference: The requested method(s) are not currently supported; class=Ssh"

Yeah, it seems like an upstream issue in libssh2: . In order to track the process in upstream, I'll keep this open and marked as `S-blocked-external`.