Weihang Lo comments

Results 766 comments of


                                            Weihang Lo

fix(env): cargo:rerun-if-env-changed doesn't work with env configuration

No worries @heisen-li. Your help here is appreciated. I'll close this in favor of #14756. Thanks you!

Introduce 'nice' value under cargo.toml -> [build]

FWIW, OOM killed issue is tracked in https://github.com/rust-lang/cargo/issues/9157, as there might be other specific approaches for it.

Allow overriding of the libgit2 pkgconfig at build time

Hi @ReillyBrogan. Thank you for the contribution. I have a mixed feeling with this change. While it does fix the issue, it is a bit uncomfortable that we are able...

Allow overriding of the libgit2 pkgconfig at build time

Could you help document the environment variable somewhere in the root `README.md` or `lib.rs` of libgit2-sys? (I think I have missed documenting `LIBGIT2_NO_VENDOR` 😅)

test: Add test codebase for shell completions

@rustbot author

pragmatically compare timestamps (as suggested by kornelski)

@rfcbot fcp merge This helps mitigate the needless rebuild when a filesystem supports only low-precision mtime, with a caveat: > there's only one in a billion chance that the nanosecond...

Reduce disk size taken up by rust standard library docs

Try the [`minimal`](https://rust-lang.github.io/rustup/concepts/profiles.html?highlight=minimal#profiles) profile when installing. And only add necessary component when needed.

Allow same source git patches with different rev / branch, etc.

Semi-related: https://github.com/rust-lang/cargo/issues/10667 Source replacement for git URL doesn't support rev and branch.

Allow same source git patches with different rev / branch, etc.

Just found this is exactly the same issue as . Close in favor of that.

Pathspec support for magic words

This crate provides bindings for [the libgit2 C library](https://github.com/libgit2/libgit2/). IIRC it only offers fnmatch-based pathspec syntax. You might want to open an issue in that repo instead.