Weihang Lo

Results 766 comments of Weihang Lo

> add a flag to rustc that sets a different folder to use as the root relative to which diagnostics are printed. How does this revert #4788 > Or we...

Have mixed feeling about suppressing this warning. It's simple enough that we can just do it. OTOH it also bloats the CLI and configuration interface for such a non-harmful warning...

So maybe adding a `install.path-check = ` configuration is good enough? I don't think anyone needs it as a hard error, so no need to have enum options like `diabled|warn|forbid`.

> Would it be possible to implement a preflight like endpoint in crates.io to do the validation **before** the publish? The solution should come from a discussion with crates.io team....

Could you provide * The Rust toolchain version you use * The expected output * The actual error you've got * The minimal complete reproduction (I don't know what command...

Just fly-by. Two issues with clear reproduction steps for reference: * https://github.com/rust-lang/cargo/issues/14015 * Highlight the baseline and followed up modification triggered the bug. * https://github.com/rust-lang/cargo/issues/14348 * Clearly captured each step...

Can `--incompatible` be used in conjunction with `--package`? Just recall and not sure about the implication of `cargo update --incompat -p `.

I believe you've tried this. Just asking in case we forgot: Have you used the `[patch]` table to patch deno's Cargo.toml? The other way can help upstream is helping them...

Both of you hold valid points. As a downstream user, it's pretty reasonable we just want to fix our build and move on. As a Cargo maintainer whose decision might...

Just try to scratch the surface of syntax. Probably `[source."*"]` is a choice? Cargo already has the config key `[profile.dev.package."*"]` in [profile overrides](https://doc.rust-lang.org/nightly/cargo/reference/profiles.html#overrides).