Weihang Lo

Results 766 comments of Weihang Lo

`[source."*"]` may not be the best choice, since it's already a valid source name today. Even `.cargo/config.toml` of every package in the world were migrated to the new semantic of...

It sounds absolutely like what ehuss said, and I have no doubt in their memory of Cargo's history.

> I'm presuming the command passed to rustc ends up being `-C strip=symbols -C strip=debuginfo` (or similar) and thus the strip mode gets overridden? Yeah your observation is correct. It's...

Another approach is we move `cargo rustc -- ` to one line below: https://github.com/rust-lang/cargo/blob/d3e84f01ff48d19892035b77db7e9c4eda87bf1f/src/cargo/core/compiler/mod.rs#L686 It has less impact to the precedence of other user-overridable rustflags (`build.rustflags` and `RUSTFLAGS`). I am...

I have already put this on the Cargo triage agenda, but I was out for family issues for the past two weeks. A zulip thread sounds good to me as...

See . This is kinda accepted with some requirements: * Make the patch enabled on nightly only. And provide an opt-out mechanism while waiting for feedback. * Make it clear...

Re-opened to track the stabilization of #14587. In case of the new precedence start blocking your builds, please let us know and use `__CARGO_RUSTC_ORIG_ARGS_PRIO=1` to restore to the original precedence.

> @rustbot transfer cargo TIL 😬 > This is expected behavior. `cargo run` is trying to act as if you ran the binary directly. `cargo test` needs a predictable location...

> What's the earliest rustc version that supports `rust-version` in `Cargo.toml`? [1.56](https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#rust-version), though Cargo's MSRV-aware resolver recognizes it even when the version is older than 1.56. So maybe use [`cargo-msrv`](https://crates.io/crates/cargo-msrv)...