Wouter Deconinck
Wouter Deconinck
Use an updated base branch. Until you do, checks will fail.
It adds code that isn't tested in CI. Does it work? Does it still work? It isn't possible to tell when it stops working. This fits more in the snippets...
@cpecar @c-dilks What is the status on this PR? Do we want to complete this before end of March to include in campaign?
Is this branch still under development? Can you rebase, fix merge conflicts, and comment when it's ready?
> Is this branch still under development? Adding @chchatte92. Can you pick this up if needed, or close if not needed?
> @wdconinc Is this going in for February? This is a CI feature. Irrelevant for production and won't go in soon due to not completed.
Barrel ecal support doesn't include rails, right? I don't think that's in the parameter table.
FYI, https://github.com/AIDASoft/DD4hep/pull/1105 has been backported into our environment so rotations should now be respected.
Is there a way we can cherry pick the material scan script into a separate PR and merge it independently?